This reverts commit 6c76b76dc64183eb2f24a52b90d4ff9feb4872f4. The reverted commit worked around a potential timing issue where the link could be reported down immediately after the link was enabled during device start. The commit introduced a blocking wait which gave the driver a better chance to read the correct link state before returning from device start. However, since the auto link update flag is set when setting the link up in device start, an adminq notification should arrive once the link is up, which will be handled and correctly set the link status. This means we can remove the delay from device start as it does not need to guarantee link up before returning.
Signed-off-by: Ciara Loftus <[email protected]> --- drivers/net/intel/ice/ice_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c index d2734b6688..da570d03cb 100644 --- a/drivers/net/intel/ice/ice_ethdev.c +++ b/drivers/net/intel/ice/ice_ethdev.c @@ -4464,7 +4464,7 @@ ice_dev_start(struct rte_eth_dev *dev) ice_dev_set_link_up(dev); /* Call get_link_info aq command to enable/disable LSE */ - ice_link_update(dev, 1); + ice_link_update(dev, 0); pf->adapter_stopped = false; -- 2.43.0
