> Subject: Re: [PATCH 1/2] net/ice: revert fix link up when starting device
>
> On Wed, Jun 03, 2026 at 02:34:06PM +0000, Ciara Loftus wrote:
> > This reverts commit 6c76b76dc64183eb2f24a52b90d4ff9feb4872f4.
> >
> > The reverted commit worked around a potential timing issue where the
> > link could be reported down immediately after the link was enabled
> > during device start. The commit introduced a blocking wait which gave
> > the driver a better chance to read the correct link state before
> > returning from device start. However, since the auto link update flag is
> > set when setting the link up in device start, an adminq notification
> > should arrive once the link is up, which will be handled and correctly
> > set the link status. This means we can remove the delay from device
> > start as it does not need to guarantee link up before returning.
> >
> > Signed-off-by: Ciara Loftus <[email protected]>
> > ---
> > drivers/net/intel/ice/ice_ethdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> Should this revert be marked for backport, or is it safer to keep the LTS's
> as they are?
I think it shouldn't be marked for backport.
With this patch we now rely on the adminq link status notification to
correct an incorrect link status read at dev_start. That requires commit
e01265e4a9bf ("net/ice: get link status updates via adminq message")
which was only introduced this year and not present in any LTS.
