On Fri, 5 Jun 2026 at 20:12, Stephen Hemminger <[email protected]> wrote: > > > > Looking at bugzilla, we had various fixes for LTO over the years. > > We still have one open bz btw: https://bugs.dpdk.org/show_bug.cgi?id=1709 > > That bug was fixed a while back. It required addition of hints (__rte_assume)
I have trouble identifying the changes. Please close the 1709 bugzilla with a mention of those changes. > > > > LTO is kind of experimental, so it seems good enough to reply "not > > > > expected to work in older LTS" if someone reported an issue. > > > > > > > > And in practice, no LTS release call the versioning macros, since a > > > > LTS drops all compatibility. > > > > Just to be clear, we don't need fixing the macros in LTS: every time > > we prepare a LTS rc0, we drop any kind of symbol compat. > > Agree, this is not LTS related > > > > > > > > > > Signed-off-by: Stephen Hemminger <[email protected]> > > > > > > > > I would like to reproduce, but I can't build main with LTO. > > > > What patches did you apply locally to avoid warnings on the hash > > > > library? > > > I use Debian testing and GCC 15 but shows up on older versions as well > > > I get no warnings building main > > > > Building from scratch, I do avoid the warnings I hit yesterday. > > > > The fix looks correct, my problem is with the form. > > Fixes: tags accuracy is important. > > And I prefer we stick to "It is not broken, don't fix it". > > Could argue it is a GCC bug, and applying their desired workaround :-) Indeed, but the end results is the same for me :-) Can you send a v2? Thanks. -- David Marchand
