On Thu, Jun 11, 2026 at 12:59:55PM +0100, Loftus, Ciara wrote:
> > Subject: Re: [PATCH v3] net/iavf: fix to consolidate link change event
> > handling
> >
> > On Wed, Jun 10, 2026 at 03:34:27PM +0100, Loftus, Ciara wrote:
> > > > Subject: [PATCH v3] net/iavf: fix to consolidate link change event
> > > > handling
> > > >
> > > > Handled link-change events through a common static function that
> > > > reads the correct advanced & legacy link fields properly and
> > > > updates no-poll/watchdog/LSC state consistently.
> > > >
> > > > Fixes: 5e03e316c753 ("net/iavf: handle virtchnl event message without
> > > > interrupt")
> > > > Fixes: 48de41ca11f0 ("net/avf: enable link status update")
> > > > Cc: [email protected]
> > > >
> > > > Signed-off-by: Anurag Mandal <[email protected]>
> > >
> > > Thanks Anurag.
> > >
> > > Acked-by: Ciara Loftus <[email protected]>
> > >
> > Just to confirm something here: does this change fix an actual underlying
> > issue, or is it just a code cleanup? If the latter we probably don't want
> > to backport it, but if it is a bug-fix, I'd like to include some details in
> > the commit log of what the observed issue was.
>
> Hi Bruce, I believe there 2 underlying issues being fixed here:
>
> 1. Ensuring LSC event is sent to the application AFTER configuring
> watchdog/no_poll state.
> 2. Ensuring watchdog is re-armed on LSC event, if a reset is detected.
> (Before it was only re-armed if link was down).
>
> The comment in the new function iavf_handle_link_change_event explains
> the reasoning. Perhaps an update to the commit message could be pulled
> from there.
>
> Thanks,
> Ciara
>
Patch applied to next-net-intel with title reworded and some additional
text on the commit log. Anurag and Ciara, please review the applied commit
log to check it is ok with you.
/Bruce
