While implementing JIT for packet capture ran into several issues:
1. x86 JIT had pre-existing bug which would crash
2. ARM64 BPF JIT was missing instructions for packet access.
Which had been discovered previously [1]
3. Tests related to JIT were not being run or missing coverage.
Fixed all of these. Patches are ordered so that most urgent fix
is first, follwed by the test that should have caught the problem.
The arm64 epilogue branch fix (patch 3) was originally posted by Christophe
Fontaine [1]; that series stalled, so it is carried here with his
authorship.
Changes since v1:
- add x86 BPF_JSET encoding fix and a regression test (patches 1-2),
found once the convert test ran generated code through the JIT
- carry Christophe's arm64 epilogue fix with his sign-off (patch 3)
- convert test now runs the converted filters through the JIT, not just
loads them (patch 6)
- kept Marat's ack (patch 4)
Since tests change enough, decided to drop his ack for that part.
[1] https://inbox.dpdk.org/dev/[email protected]/
Christophe Fontaine (1):
bpf/arm64: fix offset type to allow a negative jump
Stephen Hemminger (5):
bpf/x86: fix JIT encoding of BPF_JSET with immediate
test/bpf: add JSET test with small immediate
test/bpf: check that JIT was generated
bpf/arm64: add BPF_ABS/BPF_IND packet load support
test/bpf: check that bpf_convert can be JIT'd
app/test/test_bpf.c | 184 ++++++++++++++++++++++++++++++++++++----
lib/bpf/bpf_jit_arm64.c | 153 ++++++++++++++++++++++++++++++++-
lib/bpf/bpf_jit_x86.c | 2 +-
3 files changed, 321 insertions(+), 18 deletions(-)
--
2.53.0
