Hi, > -----Original Message----- > From: Stephen Hemminger <[email protected]> > Sent: Monday, June 29, 2026 4:10 AM > To: Gagandeep Singh <[email protected]> > Cc: [email protected]; Hemant Agrawal <[email protected]> > Subject: Re: [PATCH v3 0/9] ENETC driver related changes series > > On Tue, 23 Jun 2026 11:29:55 +0530 > Gagandeep Singh <[email protected]> wrote: > > > V3 changes: > > - Added documentation for all devargs in enetc4.rst. > > - Fixed kvlist memory leak issue. > > > > V2 changes: > > - Fixed an un-used variable compilation issue reported on fedora:43-gcc- > minsize > > - Fixed various AI reported issues: > > - Release notes updated for all new devargs > > - enect4.ini features doc updated for scattered RX. > > - removed Not required RTE_PTYPE_UNKNOWN. > > - Fixed mid-frame mbuf leak in SG case. > > - Enabled SG for enetc4 PF also. > > - move to calloc from rte_zmalloc in parse_txq_prior(). > > - added vaidation checks on strdup, strtoul. > > - added NC devargs to use cacheable ops conditionally. > > - removed dead code like bd_base_p etc. > > - Fixed rte_cpu_to_le_16() conversion on flags and combined > > all flags related patches in one patch. > > - Fixed memory leak issue due to TXQ priority patch. > > - There were some false positives, I have ignored them: > > Race condition on flags field: > > clean_tx_ring only touches HW-completed BDs > (next_to_clean→hwci), > > never newly-submitted BDs; doorbell hasn't fired yet. > > Missing dcbf in clean_tx_ring: > > DPDK is single-threaded per queue; TX path always overwrites > > flags completely before dcbf. > > TX dcbf granularity with wrap: > > Safe (AI admits it). > > RX refill flush at wrap: > > In-loop dcbf at i & mask == 0 already flushes aligned groups; > > trailing flush only needed for partial groups. > > RX reading before invalidate: > > dccivac precedes the read for every group in the loop > > > > Gagandeep Singh (7): > > net/enetc: fix TX BD structure > > net/enetc: fix queue initialization > > net/enetc: support ESP packet type in packet parsing > > net/enetc: update random MAC generation code > > net/enetc: add option to disable VSI messaging > > net/enetc: add devargs to control VSI-PSI timeout and delay > > net/enetc4: add cacheable BD ring support with SW cache maintenance > > > > Vanshika Shukla (2): > > net/enetc: support scatter-gather > > net/enetc: set user configurable priority to TX rings > > > > doc/guides/nics/enetc4.rst | 62 +++- > > doc/guides/nics/features/enetc4.ini | 1 + > > doc/guides/rel_notes/release_26_07.rst | 10 + > > drivers/net/enetc/base/enetc_hw.h | 13 +- > > drivers/net/enetc/enetc.h | 31 +- > > drivers/net/enetc/enetc4_ethdev.c | 172 ++++++++-- > > drivers/net/enetc/enetc4_vf.c | 206 ++++++++++-- > > drivers/net/enetc/enetc_ethdev.c | 25 +- > > drivers/net/enetc/enetc_rxtx.c | 430 ++++++++++++++++++++++--- > > 9 files changed, 831 insertions(+), 119 deletions(-) > > > > LOL AI apologized for missing this in review. > > You're right, and I missed it — twice. I explicitly considered that txbd > guard in my > v2 review and talked myself out of flagging it as "over-defensive," but the > runtime > argument (the inner loop always executes because tx_pkts[start] is non-NULL) > is > invisible to the compiler. Under -Werror=maybe-uninitialized at -Os that's a > hard > build break, and per-commit buildability is non-negotiable. That's a real > review > failure on my part. Let me reproduce it, pin down which patch introduces it, > and > confirm the fix. > > drivers/net/enetc/enetc_rxtx.c > > enetc_xmit_pkts_nc() and enetc_xmit_pkts_cacheable() both fail to > build with -Werror=maybe-uninitialized (-Os, gcc): > > error: 'txbd' may be used uninitialized > > txbd is declared without an initializer and assigned only inside the > inner per-segment loop; the compiler cannot prove that loop runs > before txbd is read after it. Initialize at declaration: > > - struct enetc_tx_bd *txbd; > + struct enetc_tx_bd *txbd = NULL; > > The _nc fix belongs in patch 5 (so that commit builds independently); > the _cacheable fix belongs in patch 9. >
Thanks for reporting, I have submitted the V4 with fix.
