On Mon, 29 Jun 2026 at 02:42, fengchengwen <[email protected]> wrote: > > Acked-by: Chengwen Feng <[email protected]> > > Minor suggestion: how about replace "bool do_mp = internal_conf->no_shconf == > 0;" to "bool do_mp = !!internal_conf->no_shconf;" or bool do_mp = > internal_conf->no_shconf;" > > the no_shconf's prototype is "volatile unsigned", most of invokation is some > like "if (internal_conf->no_shconf)"
This flag should have been a bool in the first place... Most of this code is already not compliant with DPDK coding style, I don't mind updating for consistency. -- David Marchand
