This addresses Bruce Richardson's review of the v4 "Intel network drivers enhancements" series. Bruce questioned the no_runtime_queue_setup devarg added in v4:
> Do we really need a commandline arg for this? If it's known enough to > have the extra arg passed at device init, is it not also known enough > to have the app not do dynamic reconfiguration in the first place? > > Alternatively, if the user configures packet pacing through rte_tm, > can we not at that point adjust the driver to disallow runtime config > by returning -ENOTSUP when reconfig is attempted, and no longer > advertising the capabilities? Runtime configuration, whether with or > without user interaction, should be preferred over devargs whenever > possible. Patch 2/2 drops the devarg and makes the driver withdraw RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP / _TX_QUEUE_SETUP automatically as soon as a per-queue bandwidth rte_tm hierarchy is committed, and re-advertise them once it is torn down. Two bugs found while making the committed-hierarchy pointer load-bearing for that check (a leak on repeated commits, and a stale pointer surviving a VF reset) are fixed alongside it. Patch 1/2 is a small documentation fix for the rl_burst_size devarg wording, spotted while touching the same area. This v5 replaces v4 patches 3/5 and 4/5 with the two patches below. v4 patches 1, 2 and 5 (max ring descriptors, queue rate limit configuration, and the testpmd pinned-rxpool command) are unchanged and are not reposted here. Dawid Wesierski (2): doc: fix ice scheduler rate-limiter burst size description net/iavf: disable runtime queue setup during queue rate limiting doc/guides/nics/ice.rst | 7 ++++--- doc/guides/nics/intel_vf.rst | 10 ++++++++++ doc/guides/rel_notes/release_26_07.rst | 3 +++ drivers/net/intel/iavf/iavf_ethdev.c | 23 ++++++++++++++++++++--- drivers/net/intel/iavf/iavf_tm.c | 2 ++ 5 files changed, 39 insertions(+), 6 deletions(-) -- 2.47.3 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
