On Wed, Jul 08, 2026, Bruce Richardson wrote: > > The paragraph describing the ``rl_burst_size`` devarg was mangled > > (a mid-sentence line break split "favours throughput" across two > > lines with no space), > > Are you sure? It looks fine to me in output generated on my machine. Also, > it's unlikely that changing the source text to add a line break between > "favours" and "throughput" will cause a line break to be removed in the > output.
Tbh im not sure. I've dropped the re-wrapping in v6. Your comment makes sense to me. > However, the rest of the patch rewrapping the text actually goes against > DPDK documentation policy. In order to keep doc diffs small, we try to > always start a sentence on a new line, and to only break lines at > punctuation marks, or between clauses generally. This saves having massive > diffs as the source text is re-wrapped following a change at the start of a > paragraph. > > See > https://doc.dpdk.org/guides/contributing/documentation.html#line-length-and-wrapping Fixed in v6. Each sentence now starts on a new line. > When they are rejected, is an error just logged, or does the driver fail to > load due to an incorrect value? IF it's just a log message, is it better to > have the driver do a hard-failure so the user can't miss the issue? That > would be better than just noting this in the docs. It is a hard failure. ice_cfg_rl_burst_size() validation failure in ice_dev_init() returns -EINVAL, causing the device probe to fail. I've updated the documentation text to explicitly state that the driver will fail to initialize if an invalid value is provided. Thanks for the review! Regards, Dawid --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
