Re: [PATCH 3/3] net/iavf: fix crash in TM ops without QoS capability

[Bruce Richardson]

On Wed, Oct 14, 2026 at 12:24:18PM +0000, Dawid Wesierski wrote:
> The VF allocates qos_cap and initializes the TM lists only when the PF
> grants VIRTCHNL_VF_OFFLOAD_QOS. The in-tree ice PF does not grant it.
> On such a VF, node add, shaper profile add, capabilities get, and node
> capabilities get dereference a NULL qos_cap, or insert into a list that
> has no initialization. The application gets a segmentation fault from a
> call such as rte_tm_capabilities_get().
> 
> Return -ENOTSUP from these operations when qos_cap is NULL. The other
> TM operations only search the lists, or check VIRTCHNL_VF_OFFLOAD_QOS
> already, so they do not need the check.
> 
> Fixes: 44d0a720a538 ("net/iavf: query QoS capabilities and set queue TC 
> mapping")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Dawid Wesierski <dawid.wesier...@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richard...@intel.com>