This series addresses the post-merge review of the AMD NTB support by Stephen. Some of the issues also exist in the Intel code and in released versions; those patches are tagged for stable.
- Patches 1-4 fix the type confusion in rte_pmd_ntb_get_mem_align(), the unbounded peer memory window count, the off-by-one in the address remapping and the memory window leaks. - Patch 5 fixes the doorbell interrupts with vfio-pci: only MSI-X vector 0 (DB0) was serviced, so the DB1/DB2 exchange of dev_stop never completed and the stop waited for its 1s timeout. - Patch 7 removes the AMD hardware event handling, which could not run as wired, and documents that hardware events are not handled. - Patches 8-9 fix the Rx path: a partially consumed packet was leaked and desynchronized the ring, and an mbuf owned by the application could be freed again on device stop. - The other patches are documentation and cleanup. The peer memory window size check suggested for the AMD handshake is not added: all the AMD scratchpads are in use, and the window limit register programmed with the local memzone length already bounds what the peer can reach. Tested with vfio-pci on two AMD EPYC Embedded hosts: handshake, file transfer, and stop/quit with DB1/DB2 exchange. Raghavendra Ningoji (13): raw/ntb: fix device check in memory alignment query raw/ntb: fix peer memory window count check raw/ntb: fix memory window bound in address remapping raw/ntb: fix memory leaks raw/ntb: fix doorbell interrupts with VFIO MSI-X raw/ntb: fix AMD processor names raw/ntb: remove AMD hardware event handling raw/ntb: fix Rx of incomplete packets raw/ntb: fix double free of Rx mbufs on stop examples/ntb: fix raw/ntb library linking doc: add NTB device info change to ABI section doc: add IOVA requirement for NTB raw/ntb: remove unused AMD register definitions doc/guides/rawdevs/ntb.rst | 12 ++- doc/guides/rel_notes/release_26_11.rst | 6 +- drivers/raw/ntb/ntb.c | 136 ++++++++++++++++++++----- drivers/raw/ntb/ntb.h | 7 +- drivers/raw/ntb/ntb_hw_amd.c | 54 ++-------- drivers/raw/ntb/ntb_hw_amd.h | 25 +---- drivers/raw/ntb/ntb_hw_intel.c | 9 +- examples/ntb/Makefile | 3 +- 8 files changed, 149 insertions(+), 103 deletions(-) -- 2.34.1
