On Wed, 11 Nov 2026 at 08:11, Raghavendra Ningoji <[email protected]> wrote: > > This series addresses the post-merge review of the AMD NTB support > by Stephen. Some of the issues also exist in the Intel code and in > released versions; those patches are tagged for stable. > > - Patches 1-4 fix the type confusion in rte_pmd_ntb_get_mem_align(), > the unbounded peer memory window count, the off-by-one in the > address remapping and the memory window leaks. > > - Patch 5 fixes the doorbell interrupts with vfio-pci: only MSI-X > vector 0 (DB0) was serviced, so the DB1/DB2 exchange of dev_stop > never completed and the stop waited for its 1s timeout. > > - Patch 7 removes the AMD hardware event handling, which could not run > as wired, and documents that hardware events are not handled. > > - Patches 8-9 fix the Rx path: a partially consumed packet was leaked > and desynchronized the ring, and an mbuf owned by the application > could be freed again on device stop. > > - Patches 14-16 fix the peer device status accesses between the > interrupt thread and the stop/data paths, and the missing checks and > leaks at queue setup. > > - The other patches are documentation and cleanup. > > The peer memory window size check suggested for the AMD handshake is > not added: all the AMD scratchpads are in use, and the window limit > register programmed with the local memzone length already bounds what > the peer can reach. > > Tested with vfio-pci on two AMD EPYC Embedded hosts: handshake, > file transfer, and stop/quit with DB1/DB2 exchange. > > --- > Changes since v2: > - Resent with proper threading: in v2, all the patches replied to the > v1 cover letter, so patchwork did not group them as a series and the > CI could not apply them. No change in patches 1-15, apart from the > rebase on current main. > - Added patch 16 for the queue setup leaks reported by Stephen on v2.
There was again a hiccup with the CI on the v3, probably something wrong in your mailing setup. I had a look at the changes, and nothing looks out of place. I ran my compilation checks, some GHA checks, all passed. Thanks for the fixes. Series applied. -- David Marchand
