> -----Original Message----- > From: Wang, Zhihong > Sent: Wednesday, June 01, 2016 4:28 AM > To: dev at dpdk.org > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > thomas.monjalon at 6wind.com; Wang, Zhihong > Subject: [PATCH v2 1/5] testpmd: add retry option > > This patch adds retry option in testpmd to prevent most packet losses. > It can be enabled by "set fwd <mode> retry". All modes except rxonly > support this option. > > Adding retry mechanism expands test case coverage to support scenarios > where packet loss affects test results. > > > Signed-off-by: Zhihong Wang <zhihong.wang at intel.com>
... > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -249,8 +249,10 @@ set fwd > > Set the packet forwarding mode:: > > - testpmd> set fwd (io|mac|mac_retry|macswap|flowgen| \ > - rxonly|txonly|csum|icmpecho) > + testpmd> set fwd (io|mac|macswap|flowgen| \ > + rxonly|txonly|csum|icmpecho) (""|retry) > + > +``retry`` can be specified for forwarding engines except ``rx_only``. > > The available information categories are: > > @@ -260,8 +262,6 @@ The available information categories are: > > * ``mac``: Changes the source and the destination Ethernet addresses of > packets before forwarding them. > > -* ``mac_retry``: Same as "mac" forwarding mode, but includes retries if the > destination queue is full. > - > * ``macswap``: MAC swap forwarding mode. > Swaps the source and the destination Ethernet addresses of packets before > forwarding them. > > @@ -392,7 +392,7 @@ Set number of packets per burst:: > > This is equivalent to the ``--burst command-line`` option. > > -In ``mac_retry`` forwarding mode, the transmit delay time and number of > retries can also be set:: > +When retry is enabled, the transmit delay time and number of retries can > also be set:: > > testpmd> set burst tx delay (micrseconds) retry (num) Could you fix the typo "micrseconds" in this patch? > > -- > 2.5.0 Apart from this, Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>