On Fri, Nov 18, 2016 at 3:26 PM, Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > Hi Thomas, > > > > I got this email when sending a patch some minutes ago. > > > > The point is I trusted script/checkpatches.sh which did not report those > > warnings. > > Am I doing anything wrong when using checkpatches.sh? > > > > > > ---------- Forwarded message ---------- > > From: <checkpatch at dpdk.org> > > Date: Fri, Nov 18, 2016 at 3:04 PM > > Subject: |WARNING| [PATCH] nfp: report link speed using hardware info > > To: test-report at dpdk.org > > Cc: Alejandro Lucero <alejandro.lucero at netronome.com> > > > > > > Test-Label: checkpatch > > Test-Status: WARNING > > http://dpdk.org/patch/17091 > > > > _coding style issues_ > > > > > > CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible > side-effects? > > #53: FILE: drivers/net/nfp/nfp_net.c:806: > > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) > > btw, you can benefit from RTE_DIM: > > lib/librte_eal/common/include/rte_common.h:352: > #define RTE_DIM(a) (sizeof (a) / sizeof ((a)[0])) > > Thanks! I will use it in the next patch version. > > > > CHECK:BRACES: Blank lines aren't necessary after an open brace '{' > > #91: FILE: drivers/net/nfp/nfp_net.c:856: > > + else { > > + > > > > total: 0 errors, 0 warnings, 2 checks, 68 lines checked > > > >
