On Fri, Nov 18, 2016 at 3:31 PM, Alejandro Lucero < alejandro.lucero at netronome.com> wrote:
> > > On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit <ferruh.yigit at intel.com> > wrote: > >> On 11/18/2016 3:10 PM, Alejandro Lucero wrote: >> > Hi Thomas, >> > >> > I got this email when sending a patch some minutes ago. >> > >> > The point is I trusted script/checkpatches.sh which did not report those >> > warnings. >> > Am I doing anything wrong when using checkpatches.sh? >> >> I am also getting same warnings as below, this can be related to the >> checkpatch.pl version. >> >> I have: Version: 0.32 >> (./scripts/checkpatch.pl --version) >> >> > Uhmm, I got same one. > > Ok. It seems I suffered a temporal blindness. I though the automatic report was about warnings but it is about checks. But I got just one of the checks messages. This is the output with -v and adding OPTIONS used: ### [PATCH] nfp: report link speed using hardware info OPTIONS: --no-tree --max-line-length=80 --show-types --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,NEW_TYPEDEFS,COMPARISON_TO_NULL CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #60: FILE: drivers/net/nfp/nfp_net.c:856: + else { + total: 0 errors, 0 warnings, 1 checks, 68 lines checked 0/1 valid patch > > >> > >> > ---------- Forwarded message ---------- >> > From: <checkpatch at dpdk.org> >> > Date: Fri, Nov 18, 2016 at 3:04 PM >> > Subject: |WARNING| [PATCH] nfp: report link speed using hardware info >> > To: test-report at dpdk.org >> > Cc: Alejandro Lucero <alejandro.lucero at netronome.com> >> > >> > >> > Test-Label: checkpatch >> > Test-Status: WARNING >> > http://dpdk.org/patch/17091 >> > >> > _coding style issues_ >> > >> > >> > CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible >> side-effects? >> > #53: FILE: drivers/net/nfp/nfp_net.c:806: >> > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) >> > >> > CHECK:BRACES: Blank lines aren't necessary after an open brace '{' >> > #91: FILE: drivers/net/nfp/nfp_net.c:856: >> > + else { >> > + >> > >> > total: 0 errors, 0 warnings, 2 checks, 68 lines checked >> > >> >> >