On 9/22/2017 5:42 PM, Jerin Jacob wrote:
-----Original Message-----
Date: Fri, 22 Sep 2017 02:47:14 +0530
From: Nikhil Rao <nikhil....@intel.com>
To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com
CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net,
harry.van.haa...@intel.com, hemant.agra...@nxp.com, nipun.gu...@nxp.com,
narender.vang...@intel.com, erik.g.carri...@intel.com,
abhinandan.guj...@intel.com, santosh.shu...@caviumnetworks.com
Subject: [PATCH v4 4/4] eventdev: Add tests for event eth Rx adapter APIs
X-Mailer: git-send-email 2.7.4
Add unit tests for rte_event_eth_rx_adapter_xxx() APIs
<snip>
+#include <string.h>
+#include <rte_common.h>
+#include <rte_mempool.h>
+#include <rte_mbuf.h>
+#include <rte_ethdev.h>
+#include <rte_eventdev.h>
+
+#include <rte_event_eth_rx_adapter.h>
+
+#include "test.h"
+
+/* i40e limits max to 64 */
This comment could be removed.
OK, I am documenting why the code doesn't just use
dev_info.max_rx_queues, won't the comment be useful to retain ?
+#define MAX_NUM_RX_QUEUE 64
+#define NB_MBUFS (8192 * num_ports * MAX_NUM_RX_QUEUE)
+#define MBUF_CACHE_SIZE 512
+#define MBUF_PRIV_SIZE 0
+
+struct event_eth_rx_adapter_test_params {
+ struct rte_mempool *mp;
+ uint16_t rx_rings, tx_rings;
+ uint32_t caps;
+};
+
+static struct event_eth_rx_adapter_test_params default_params;
+
+static int
+testsuite_setup(void)
+{
+ int err;
+ err = init_ports(rte_eth_dev_count());
+ TEST_ASSERT(err == 0, "Port initialization failed err %d\n", err);
I guess, We check rte_event_dev_count() >= 1 before proceeding.
Yes, I can add the same logic as in test_evendev.
+
+ struct rte_event_dev_config config = {
+ .nb_event_queues = 1,
+ .nb_event_ports = 1,
+ .nb_events_limit = 4096,
+ .nb_event_queue_flows = 1024,
+ .nb_event_port_dequeue_depth = 16,
+ .nb_event_port_enqueue_depth = 16
+ };
+
+ err = rte_event_dev_configure(0, &config);
+ TEST_ASSERT(err == 0, "Event device initialization failed err %d\n",
+ err);
+
+ err = rte_event_eth_rx_adapter_caps_get(0, 0, &default_params.caps);
+ TEST_ASSERT(err == 0, "Failed to get adapter cap err %d\n",
+ err);
+
+ return err;
+}
+
Thanks for the review,
Nikhil
