Xiao told me that this series (except the last patch) was already applied
to the Thomas master branch. I then realised it was my mistake.
I applied v10 last week locally for some basic testing. There is a conflict
in last patch, that's why the last patch is not merged. I forgot to do
a reset before I applied another patch. Then later, I did a push to the
next-virtio tree, thus patches from Xiao were also pushed. Ferruh then
did a pull from it. As a result, they got merged to the master branch
before I realised. Non-rebase is allowed there, thus I have made a patch
to fix my mistake.
Meanwhile, I have also spotted a build error when shared lib is enabled.
I will send them out soon.
--yliu
On Wed, Jan 17, 2018 at 05:40:58AM +0800, Xiao Wang wrote:
> When live migration is finished, the backup VM needs to proactively announce
> its new location. DPDK vhost has implemented VHOST_USER_PROTOCOL_F_RARP to
> generate a RARP packet to switch in dequeue path. Another method is to let
> the guest proactively send out RARP packet using VIRTIO_NET_F_GUEST_ANNOUNCE
> feature.
>
> This patch set enables this feature in virtio pmd, to support VM running
> virtio
> pmd be migrated without vhost supporting RARP generation.
>
> v11:
> - Add check for parameter and tailroom in rte_net_make_rarp_packet.
> - Allocate mbuf in rte_net_make_rarp_packet.
>
> v10:
> - Add a bold doxygen comment for the experimental function.
>
> v9:
> - Introduce function with the experimental state.
>
> v8:
> - Add a helper in lib/librte_net to make rarp packet, it's used by
> both vhost and virtio.
>
> v7:
> - Improve comment for state_lock.
> - Rename spinlock variable 'sl' to 'lock'.
>
> v6:
> - Use rte_pktmbuf_alloc() instead of rte_mbuf_raw_alloc().
> - Remove the 'len' parameter in calling virtio_send_command().
> - Remove extra space between typo and var.
> - Improve comment and alignment.
> - Remove the unnecessary header file.
> - A better usage of 'unlikely' indication.
>
> v5:
> - Remove txvq parameter in virtio_inject_pkts.
> - Zero hw->special_buf after using it.
> - Return the retval of tx_pkt_burst().
> - Allocate a mbuf pointer on stack directly.
>
> v4:
> - Move spinlock lock/unlock into dev_pause/resume.
> - Separate out a patch for packet injection.
>
> v3:
> - Remove Tx function code duplication, use a special pointer for rarp
> injection.
> - Rename function generate_rarp to virtio_notify_peers, replace
> 'virtnet_' with 'virtio_'.
> - Add comment for state_lock.
> - Typo fix and comment improvement.
>
> v2:
> - Use spaces instead of tabs between the code and comments.
> - Remove unnecessary parentheses.
> - Use rte_pktmbuf_mtod directly to get eth_hdr addr.
> - Fix virtio_dev_pause return value check.
>
> Xiao Wang (5):
> net/virtio: make control queue thread-safe
> net/virtio: add packet injection method
> net: add a helper for making RARP packet
> vhost: use lib API to make RARP packet
> net/virtio: support GUEST ANNOUNCE
>
> drivers/net/virtio/virtio_ethdev.c | 113
> +++++++++++++++++++++++++++++++-
> drivers/net/virtio/virtio_ethdev.h | 6 ++
> drivers/net/virtio/virtio_pci.h | 7 ++
> drivers/net/virtio/virtio_rxtx.c | 3 +-
> drivers/net/virtio/virtio_rxtx.h | 1 +
> drivers/net/virtio/virtio_rxtx_simple.c | 2 +-
> drivers/net/virtio/virtqueue.h | 11 ++++
> lib/Makefile | 3 +-
> lib/librte_net/Makefile | 1 +
> lib/librte_net/rte_arp.c | 50 ++++++++++++++
> lib/librte_net/rte_arp.h | 18 +++++
> lib/librte_net/rte_net_version.map | 6 ++
> lib/librte_vhost/Makefile | 2 +-
> lib/librte_vhost/virtio_net.c | 51 +-------------
> 14 files changed, 219 insertions(+), 55 deletions(-)
> create mode 100644 lib/librte_net/rte_arp.c
>
> --
> 2.15.1
