On 1/19/2018 5:33 PM, Ferruh Yigit wrote: > On 1/16/2018 9:41 PM, Xiao Wang wrote: >> When live migration is done, for the backup VM, either the virtio >> frontend or the vhost backend needs to send out gratuitous RARP packet >> to announce its new network location. >> >> This patch enables VIRTIO_NET_F_GUEST_ANNOUNCE feature to support live >> migration scenario where the vhost backend doesn't have the ability to >> generate RARP packet. >> >> Brief introduction of the work flow: >> 1. QEMU finishes live migration, pokes the backup VM with an interrupt. >> 2. Virtio interrupt handler reads out the interrupt status value, and >> realizes it needs to send out RARP packet to announce its location. >> 3. Pause device to stop worker thread touching the queues. >> 4. Inject a RARP packet into a Tx Queue. >> 5. Ack the interrupt via control queue. >> 6. Resume device to continue packet processing. >> >> Signed-off-by: Xiao Wang <xiao.w.w...@intel.com> >> Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com> > > > Hi Yuanhan, > > This commit breaks the build!
I switched two patches and problem gone, like: first: net: fixup RARP generation second: net/virtio: support GUEST ANNOUNCE >From my point of view nothing more needs to be done, but can you please double check the patches. Thanks, ferruh > > As far as I understand you send a fix but merged into other patch, which > leaves > this commit still broken. > > What do you think sending a fix that can be mergable to this one, so I can > squash it on next-net? > > Thanks, > ferruh >
