Hi Jay,

> -----Original Message-----
> From: Jay Zhou [mailto:jianjay.z...@huawei.com]
> Sent: Monday, April 16, 2018 3:21 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; Zhang, Roy Fan
> <roy.fan.zh...@intel.com>; tho...@monjalon.net;
> arei.gong...@huawei.com; Zeng, Xin <xin.z...@intel.com>;
> weidong.hu...@huawei.com; wangxinxin.w...@huawei.com;
> longpe...@huawei.com; jianjay.z...@huawei.com
> Subject: [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD
> 
> The virtio crypto device is a virtual cryptography device as well as a kind of
> virtual hardware accelerator for virtual machines. The linux kernel 
> virtio-crypto
> driver has been merged, and this patch introduces virtio crypto PMD to achieve
> better performance.
> 
> Signed-off-by: Jay Zhou <jianjay.z...@huawei.com>
> Reviewed-by: Fan Zhang <roy.fan.zh...@intel.com>
> Acked-by: Fan Zhang <roy.fan.zh...@intel.com>

...

> +++ b/drivers/crypto/virtio/meson.build
> @@ -0,0 +1,11 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 HUAWEI
> +TECHNOLOGIES CO., LTD.
> +
> +dep = dependency('libcrypto', required: false) if not dep.found()
> +     build = false
> +endif

Does this PMD have a dependency on libcrypto?
Looking at the code, I don't think it does.
Therefore, you should remove this and also LDLIBS += -lcrypto in the Makefile.
Once this is removed, and you add the path to the virtio_crypto.h file (as 
Ferruh suggested),
I'd say this PMD can be enabled by default.

Reply via email to