Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] > Sent: Monday, April 16, 2018 10:16 PM > To: Zhoujian (jay) <jianjay.z...@huawei.com>; dev@dpdk.org > Cc: Zhang, Roy Fan <roy.fan.zh...@intel.com>; tho...@monjalon.net; Gonglei > (Arei) <arei.gong...@huawei.com>; Zeng, Xin <xin.z...@intel.com>; > Huangweidong (C) <weidong.hu...@huawei.com>; wangxin (U) > <wangxinxin.w...@huawei.com>; longpeng <longpe...@huawei.com> > Subject: RE: [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD > > Hi Jay, > > > -----Original Message----- > > From: Jay Zhou [mailto:jianjay.z...@huawei.com] > > Sent: Monday, April 16, 2018 3:21 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; Zhang, Roy > > Fan <roy.fan.zh...@intel.com>; tho...@monjalon.net; > > arei.gong...@huawei.com; Zeng, Xin <xin.z...@intel.com>; > > weidong.hu...@huawei.com; wangxinxin.w...@huawei.com; > > longpe...@huawei.com; jianjay.z...@huawei.com > > Subject: [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD > > > > The virtio crypto device is a virtual cryptography device as well as a > > kind of virtual hardware accelerator for virtual machines. The linux > > kernel virtio-crypto driver has been merged, and this patch introduces > > virtio crypto PMD to achieve better performance. > > > > Signed-off-by: Jay Zhou <jianjay.z...@huawei.com> > > Reviewed-by: Fan Zhang <roy.fan.zh...@intel.com> > > Acked-by: Fan Zhang <roy.fan.zh...@intel.com> > > ... > > > +++ b/drivers/crypto/virtio/meson.build > > @@ -0,0 +1,11 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 HUAWEI > > +TECHNOLOGIES CO., LTD. > > + > > +dep = dependency('libcrypto', required: false) if not dep.found() > > + build = false > > +endif > > Does this PMD have a dependency on libcrypto? > Looking at the code, I don't think it does. > Therefore, you should remove this and also LDLIBS += -lcrypto in the Makefile.
It's compiled successfully without the dependency, so you're right. I'll remove it. > Once this is removed, and you add the path to the virtio_crypto.h file (as > Ferruh suggested), I'd say this PMD can be enabled by default. I agree with you and Ferruh. If the other codes are fine for you, I'll send the next version tomorrow with this PMD enabled by default as well as the updated path to virtio_crypto.h file. Regards, Jay
