chrismattmann commented on a change in pull request #129: Replaced
Processwrapper indexing method with SolrIndexer
URL: https://github.com/apache/drat/pull/129#discussion_r189308674
##########
File path: proteus/src/main/java/backend/ProcessDratWrapper.java
##########
@@ -104,8 +109,18 @@ public void crawl() throws Exception {
}
@Override
- public void index() throws IOException, DratWrapperException {
- simpleDratExec(INDEX_CMD, this.path);
+ public void index() throws IOException, DratWrapperException,
InstantiationException, SolrServerException {
+// simpleDratExec(INDEX_CMD, this.path);
+ solrIndex();
+ }
+
+ private void solrIndex() throws InstantiationException, SolrServerException,
IOException {
+
System.setProperty(FileConstants.SOLR_INDEXER_CONFIG,FileConstants.SOLR_INDEXER_CONFIG_PATH);
Review comment:
TODO: eventually make this work in a multi-user, multi-context environment
if necessary. It may well support that but every time I see a System property
there's a concern it will bind us to some particular configuration. I think
this is fine for now though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
