chrismattmann commented on a change in pull request #129: Replaced 
Processwrapper indexing method with SolrIndexer
URL: https://github.com/apache/drat/pull/129#discussion_r189308217
 
 

 ##########
 File path: proteus/src/main/java/backend/FileConstants.java
 ##########
 @@ -41,4 +51,22 @@ private static String getDratDirectory() {
   public static String buildDratSubdirectoryPath(String additionalPath) {
     return DRAT_SUPER_DIR + additionalPath;
   }
+  
+  public static String replaceEnvVar(String input) {
 
 Review comment:
   Suggestion, use OODT 
[PathUtils](https://github.com/apache/oodt/blob/master/metadata/src/main/java/org/apache/oodt/cas/metadata/util/PathUtils.java)
 here. In particular, use 
[replaceEnvVariables](https://github.com/apache/oodt/blob/master/metadata/src/main/java/org/apache/oodt/cas/metadata/util/PathUtils.java#L54)
 with something like e.g., [OPSUI_URL]. So the above would be on line 42 e.g., 
   
   ```java
   public static final String OPSUI_URL = 
PathUtils.replaceEnvVariables("[OPSUI_URL]");
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to