----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26371/#review66852 -----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/26371/#comment110517> Some indentation is wrong. Can you please fix, here and in the other changes. contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/26371/#comment110516> A comment is needed here to explain why this code is needed. Ideally, this code should never be needed. Also, for optional protobuf fields, we should check if the field is set or not before checking its value. So - msg.has_rpc_type() && msg.m_rpc_type==exec::user::HANDSHAKE and msg.has_mode() && msg.m_mode==exec::rpc::REQUEST - Parth Chandra On Jan. 6, 2015, 1:06 a.m., Norris Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26371/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 1:06 a.m.) > > > Review request for drill and Parth Chandra. > > > Repository: drill-git > > > Description > ------- > > Occasionally the client will receive handshake messages from the server. > Requests should be reponded to and responses should be ignored. Spurious > Query_Handle and Query_Result messages (where coordination id and query id = > 0, respectively) should also be ignored. > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClientImpl.cpp 23dc407 > > Diff: https://reviews.apache.org/r/26371/diff/ > > > Testing > ------- > > > Thanks, > > Norris Lee > >
