----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26371/#review66911 -----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/26371/#comment110615> Did you mean to use the has_coord_id() method here? contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/26371/#comment110616> Did you forget to add has_rpc_type()? CAn you compile and make sure noting is missed out? - Parth Chandra On Jan. 6, 2015, 8:20 p.m., Norris Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26371/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 8:20 p.m.) > > > Review request for drill and Parth Chandra. > > > Repository: drill-git > > > Description > ------- > > Occasionally the client will receive handshake messages from the server. > Requests should be reponded to and responses should be ignored. Spurious > Query_Handle and Query_Result messages (where coordination id and query id = > 0, respectively) should also be ignored. > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClientImpl.cpp 23dc407 > contrib/native/client/src/clientlib/rpcDecoder.cpp c1001fd > contrib/native/client/src/clientlib/rpcMessage.hpp fa92c42 > > Diff: https://reviews.apache.org/r/26371/diff/ > > > Testing > ------- > > > Thanks, > > Norris Lee > >
