-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30697/
-----------------------------------------------------------
(Updated Feb. 7, 2015, 1:20 a.m.)
Review request for drill, Aditya Kishore, Aman Sinha, Jacques Nadeau, Jinfeng
Ni, Mehant Baid, and Parth Chandra.
Changes
-------
Removed memory changes, as they were uncesseary, made small changes in
TopLevelAllocator.getChildAllocator() to allow a null FragmentContext to be
passed int. Also did some code cleanup
Bugs: DRILL-2060
https://issues.apache.org/jira/browse/DRILL-2060
Repository: drill-git
Description
-------
Use a small modification of a rule in optiq and hook up the interpreted
expression evaluator to fold constant expressions (including those with Drill
UDFs) into literals. Fragment memory limits have been disabled, a more complete
refactoring of memory management is planned, the changes made here were to
allow the creation of a childAllocator without access to a fragment context. I
have added two comments next to the modifiations I made to the optiq rule for
our use case.
Diffs (updated)
-----
exec/interpreter/src/test/java/org/apache/drill/exec/expr/TestConstantFolding.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java
67e1fdb
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java
c881432
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConstExecutor.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java
3b7adca
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/OptiqForkedConstantReduxRule.java
PRE-CREATION
Diff: https://reviews.apache.org/r/30697/diff/
Testing
-------
This is a work in progress, some testing has been done, no full unit test run
yet
Thanks,
Jason Altekruse
