-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30697/
-----------------------------------------------------------
(Updated Feb. 28, 2015, 12:09 a.m.)
Review request for drill, Aditya Kishore, Aman Sinha, Jacques Nadeau, Jinfeng
Ni, Mehant Baid, and Parth Chandra.
Changes
-------
This issue has been split into two reviews. The changes to this portion include
mostly adding more type support to constant folding and fixing the placement of
the close() method call for query context.
Summary (updated)
-----------------
Drill-2060 - part 2 - constant expression folding during planning
Bugs: DRILL-2060
https://issues.apache.org/jira/browse/DRILL-2060
Repository: drill-git
Description (updated)
-------
THIS REQUEST HAS BEEN BROKEN INTO TWO REVIEWS:
- I had to make a fairly substandial change to the interpreteed expression
evaluation to make the tests work.
Use a small modification of a rule in optiq and hook up the interpreted
expression evaluator to fold constant expressions (including those with Drill
UDFs) into literals. Fragment memory limits have been disabled, a more complete
refactoring of memory management is planned, the changes made here were to
allow the creation of a childAllocator without access to a fragment context. I
have added two comments next to the modifiations I made to the optiq rule for
our use case.
Diffs (updated)
-----
exec/java-exec/src/main/java/io/netty/buffer/DrillBuf.java 8e9d395
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
00aaec6
exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java
67e1fdb
exec/java-exec/src/main/java/org/apache/drill/exec/ops/BufferManager.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java
e413921
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java
c881432
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConstExecutor.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java
93fff35
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceExpressionsRules.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java
3b7adca
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
d9fc997
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
710418b
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
378e81a
exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java e673230
exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/TestConstantFolding.java
PRE-CREATION
pom.xml 525579a
Diff: https://reviews.apache.org/r/30697/diff/
Testing
-------
This is a work in progress, some testing has been done, no full unit test run
yet
Thanks,
Jason Altekruse
