----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30868/#review71988 -----------------------------------------------------------
contrib/native/client/example/querySubmitter.cpp <https://reviews.apache.org/r/30868/#comment117906> Is it possible to not use Boost here? We are trying to minimize dependence on Boost contrib/native/client/src/clientlib/drillClient.cpp <https://reviews.apache.org/r/30868/#comment117927> The previous code assumed that the timeout value can never be zero. This assumption should be explicitly enforced here in the setters. If the value provided is <=0 then we should ignore the value and use the default. The updated code in this patch does not start the timer at all if the value is <=0 which is not desirable. contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/30868/#comment117909> I think you need to cancel the timer before you do anything. What if the timer expires while you're processing the handshake? contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/30868/#comment117910> I prefer the original log message. contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/30868/#comment117921> Can we have just one log message here? contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/30868/#comment117922> Why don't we need to reset the io_service if this function returns with an error? contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/30868/#comment117924> Can we merge these log messages. In general, I prefer the original log message. - Parth Chandra On Feb. 11, 2015, 8:10 a.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30868/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 8:10 a.m.) > > > Review request for drill, Alexander zarei, Norris Lee, and Parth Chandra. > > > Bugs: DRILL-1197 > https://issues.apache.org/jira/browse/DRILL-1197 > > > Repository: drill-git > > > Description > ------- > > It also > > - returns more detailed connection status for validate handshake. > - adds timeout options for query submitter. > > > Diffs > ----- > > contrib/native/client/example/querySubmitter.cpp 2d89223 > contrib/native/client/src/clientlib/drillClient.cpp 02bc1a4 > contrib/native/client/src/clientlib/drillClientImpl.hpp a5eeb77 > contrib/native/client/src/clientlib/drillClientImpl.cpp c832a79 > contrib/native/client/src/clientlib/errmsgs.hpp 9a69f21 > contrib/native/client/src/clientlib/errmsgs.cpp a5e7217 > contrib/native/client/src/include/drill/common.hpp f83aae4 > contrib/native/client/src/include/drill/drillClient.hpp 0204855 > > Diff: https://reviews.apache.org/r/30868/diff/ > > > Testing > ------- > > Tried with a long running query for query timeout. > https://github.com/apache/drill/blob/master/exec/java-exec/src/test/resources/queries/tpch/18.sql > > > ```bash > ./querySubmitter connectStr='zk=127.0.0.1:2181/drill/drillbits1' type=sql > api=async query='select c.c_name, c.c_custkey, o.o_orderkey, o.o_orderdate, > o.o_totalprice, sum(l.l_quantity) from cp.`tpch/customer.parquet` c, > cp.`tpch/orders.parquet` o, cp.`tpch/lineitem.parquet` l where o.o_orderkey > in ( select l_orderkey from cp.`tpch/lineitem.parquet` group by l_orderkey > having sum(l_quantity) > 300) and c.c_custkey = o.o_custkey and o.o_orderkey > = l.l_orderkey group by c.c_name, c.c_custkey, o.o_orderkey, o.o_orderdate, > o.o_totalprice order by o.o_totalprice desc, o.o_orderdate limit 100' > queryTimeout=1 > ``` > > > Thanks, > > Xiao Meng > >
