-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30868/
-----------------------------------------------------------

(Updated Feb. 13, 2015, 2:06 a.m.)


Review request for drill, Alexander zarei, Norris Lee, and Parth Chandra.


Changes
-------

squash with Alex's fix + indent fix.


Bugs: DRILL-1197
    https://issues.apache.org/jira/browse/DRILL-1197


Repository: drill-git


Description
-------

It also

    - returns more detailed connection status for validate handshake.
    - adds timeout options for query submitter.


Diffs (updated)
-----

  contrib/native/client/example/querySubmitter.cpp 2d89223 
  contrib/native/client/src/clientlib/drillClient.cpp 02bc1a4 
  contrib/native/client/src/clientlib/drillClientImpl.hpp a5eeb77 
  contrib/native/client/src/clientlib/drillClientImpl.cpp c832a79 
  contrib/native/client/src/clientlib/errmsgs.hpp 9a69f21 
  contrib/native/client/src/clientlib/errmsgs.cpp a5e7217 
  contrib/native/client/src/include/drill/common.hpp f83aae4 
  contrib/native/client/src/include/drill/drillClient.hpp 0204855 

Diff: https://reviews.apache.org/r/30868/diff/


Testing
-------

Tried with a long running query for query timeout.
https://github.com/apache/drill/blob/master/exec/java-exec/src/test/resources/queries/tpch/18.sql


```bash
./querySubmitter connectStr='zk=127.0.0.1:2181/drill/drillbits1' type=sql 
api=async query='select c.c_name, c.c_custkey, o.o_orderkey, o.o_orderdate, 
o.o_totalprice, sum(l.l_quantity) from cp.`tpch/customer.parquet` c, 
cp.`tpch/orders.parquet` o, cp.`tpch/lineitem.parquet` l where o.o_orderkey in 
( select l_orderkey from cp.`tpch/lineitem.parquet` group by l_orderkey having 
sum(l_quantity) > 300) and c.c_custkey = o.o_custkey and o.o_orderkey = 
l.l_orderkey group by c.c_name, c.c_custkey, o.o_orderkey, o.o_orderdate, 
o.o_totalprice order by o.o_totalprice desc, o.o_orderdate limit 100' 
queryTimeout=1
```


Thanks,

Xiao Meng

Reply via email to