-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31313/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Steven Phillips.
Bugs: DRILL-2280
https://issues.apache.org/jira/browse/DRILL-2280
Repository: drill-git
Description
-------
DRILL-2280: Refactor ValueVector interface & provide a base ValueVector
implementation
I will convert DRILL-2280 to an umbrella around ValueVector interface
refactoring alone. This issue consists of small set of changes fixing misplaced
methods.
- Added initial documentation.
- Move ValueVector.Accessor#getReader to ValueVector#getReader
- Use of generics for Accessor & Mutator's
- Misc test fixes and minor refacs
Diffs
-----
exec/java-exec/src/main/codegen/templates/EventBasedRecordWriter.java
e76178a59bd753ae68c9fe9fcf007e3665ca4174
exec/java-exec/src/main/codegen/templates/FixedValueVectors.java
52a38680aa1e7a1d5aa6e4f5d7e38337fb00783c
exec/java-exec/src/main/codegen/templates/NullableValueVectors.java
ba7c629bf4fe4d2b04f52dcb02e98b532128dc73
exec/java-exec/src/main/codegen/templates/RecordValueAccessor.java
47197315e9e45ef2b5e456e957c7914d22a51551
exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java
d39040e4731d645efc411aecf79fba69c50c4f98
exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java
f854d32c59e5be6de60b34bbc4895b3c832c98bc
exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java
a5758fba9a0e3fa53aaaaa6ca7c3b0cca1b322d7
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReader.java
2424fac7e9451bc0c92c6455ab1571786bde8572
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableColumnReader.java
c7ada6bffdea20146511150424068b33f7d4fc65
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java
8778ef8b88a13263213a9a59679fbd8a1fa999ca
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseDataValueVector.java
bc3edaae7b0c993845a6a7324240e17a646c0c74
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseValueVector.java
18da67d5f9900d4fffa2a782cb60cef9289aa72c
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java
f6644bddbd239fd5d710d73a0dc7bcb2acb1b7e8
exec/java-exec/src/main/java/org/apache/drill/exec/vector/ObjectVector.java
3c15db314184ff33f48bb7c5515b47dd98579814
exec/java-exec/src/main/java/org/apache/drill/exec/vector/ValueVector.java
df6a4860b8cd3f0ae6b102a98ed610304a0081dd
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java
3bc7d11b9d7bf7f3159041ac2235333519d17931
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java
c5dc5ba2537f249adf524844836320f4004d78ba
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java
131f2a3354a4162b22927bd9e464f32487ed2af2
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java
ad8c66fe6c11c01ded1c651577015ec16ac8ea70
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java
c51dfda69a568e3877e1edb75b179870987ecff8
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java
91362770c3265104876f772f4f50441b6e33dc4d
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/SingleListReaderImpl.java
40fa6d46fe17ac1fca013980fc2c4381c4a48abc
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/SingleMapReaderImpl.java
5c8f688d96661d4276f84c246138fd9c03523591
exec/java-exec/src/test/java/org/apache/drill/exec/expr/ExpressionTest.java
2311cfd830b78a5334848b451688bb5d6489e372
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestRepeated.java
feaef4d3f6694955012e63cd6ecc03278a6e5882
Diff: https://reviews.apache.org/r/31313/diff/
Testing
-------
unit tests.
Thanks,
Hanifi Gunes
