-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31313/
-----------------------------------------------------------
(Updated March 31, 2015, 8:56 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
- Rebased on top of master@417ad38
- Updated documentation
- Scalar vectors now extend BaseDataVV rather than BaseVV
Bugs: DRILL-2280
https://issues.apache.org/jira/browse/DRILL-2280
Repository: drill-git
Description
-------
DRILL-2280: Refactor ValueVector interface & provide a base ValueVector
implementation
I will convert DRILL-2280 to an umbrella around ValueVector interface
refactoring alone. This issue consists of small set of changes fixing misplaced
methods.
- Added initial documentation.
- Move ValueVector.Accessor#getReader to ValueVector#getReader
- Use of generics for Accessor & Mutator's
- Misc test fixes and minor refacs
Diffs (updated)
-----
exec/java-exec/src/main/codegen/templates/EventBasedRecordWriter.java
e76178a59bd753ae68c9fe9fcf007e3665ca4174
exec/java-exec/src/main/codegen/templates/FixedValueVectors.java
b922767b90a10b29a115e33aa6f605c578adbb07
exec/java-exec/src/main/codegen/templates/NullableValueVectors.java
2ec749247d63eeaa2b2c8f3ed3961d7440ca3713
exec/java-exec/src/main/codegen/templates/RecordValueAccessor.java
47197315e9e45ef2b5e456e957c7914d22a51551
exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java
ee40cc26ab3e15756fed54c90a81c69cc4a624c5
exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java
93557e2799ebb89393cd3d6f82d5aa235c9d4c88
exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java
c20ff1420de0328a74a139971a09b132ce1be990
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReader.java
2424fac7e9451bc0c92c6455ab1571786bde8572
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableColumnReader.java
c7ada6bffdea20146511150424068b33f7d4fc65
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java
9d85b67c6687b1158fe92db1eb0e2b6c23a30d95
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseDataValueVector.java
bc3edaae7b0c993845a6a7324240e17a646c0c74
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseValueVector.java
18da67d5f9900d4fffa2a782cb60cef9289aa72c
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java
a152a0e5518192e3fdc520cf13ad4fa4217062a3
exec/java-exec/src/main/java/org/apache/drill/exec/vector/ObjectVector.java
ac050e10e2c0b6fc65197349cadd3bec66d65d7c
exec/java-exec/src/main/java/org/apache/drill/exec/vector/ValueVector.java
42e25e751580e7c2da3d071f7e64e54a75047295
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java
acf9ec747dc09a99318f693fea17efeb9d8e285a
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java
54ffeb2dacc1d2e700bd7c0274b16d872ed04e20
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java
cc6818144af7e6fdae4f819439bad131896f707b
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java
5afc8899f1ea4b513a0627d34664f18be7d85089
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java
805ba895040f9e672e900643da652698f7132d87
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java
1cee5473f324665f0545b678a09ea9b486ee965d
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/SingleListReaderImpl.java
40fa6d46fe17ac1fca013980fc2c4381c4a48abc
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/SingleMapReaderImpl.java
5c8f688d96661d4276f84c246138fd9c03523591
exec/java-exec/src/test/java/org/apache/drill/exec/expr/ExpressionTest.java
2311cfd830b78a5334848b451688bb5d6489e372
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestRepeated.java
feaef4d3f6694955012e63cd6ecc03278a6e5882
Diff: https://reviews.apache.org/r/31313/diff/
Testing
-------
unit tests.
Thanks,
Hanifi Gunes
