> On March 3, 2015, 11:07 p.m., Jason Altekruse wrote: > > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java, line 37 > > <https://reviews.apache.org/r/31707/diff/1/?file=883700#file883700line37> > > > > Change all of these to unordered comparisions, there is no guarentee > > about the ordering in the case of a union all (also even though reads on a > > single file will produce an ordered result currently we shouldn't rely on > > it when writing tests)
will upload the new patch in one sec - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31707/#review75077 ----------------------------------------------------------- On March 3, 2015, 10:37 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31707/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 10:37 p.m.) > > > Review request for drill, Aman Sinha and Jinfeng Ni. > > > Bugs: DRILL-2207 > https://issues.apache.org/jira/browse/DRILL-2207 > > > Repository: drill-git > > > Description > ------- > > DRILL-2207: New Union-All Implementation > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java > 3565bf4 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAll.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java > 99aec92 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllTemplate.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java > 4c9d301 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java > 60a9e4b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java > dcd5ebf > > exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java > 7b772cc > > exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java > f5b0de4 > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java > 225b21e > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b > exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q1.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q10.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q11.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q12.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q13.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q14.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q15.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q2.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q3.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q4.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q5.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q6.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q6_1.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q7.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q8.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionAll/q9.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv > PRE-CREATION > > Diff: https://reviews.apache.org/r/31707/diff/ > > > Testing > ------- > > Design Doc can be found from: > https://issues.apache.org/jira/browse/DRILL-2207 > > Unit, Customers, TPCH passed > waiting for Functional... > > > Thanks, > > Sean Hsuan-Yi Chu > >
