----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31707/#review75808 -----------------------------------------------------------
A few more comments.. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java <https://reviews.apache.org/r/31707/#comment123123> Remove the 'is' in the first sentence. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java <https://reviews.apache.org/r/31707/#comment123124> Same as above. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java <https://reviews.apache.org/r/31707/#comment123112> Miss-match should have one 's' exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java <https://reviews.apache.org/r/31707/#comment123113> Why did you remove the super.cleanup() call ? exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java <https://reviews.apache.org/r/31707/#comment123115> This error looks different from what we throw for IterOutcome.NONE in other operators...can you check and make this consistent. exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java <https://reviews.apache.org/r/31707/#comment123129> I think referencing the 2207 JIRA is misleading here because that one will be marked Fixed once this feature goes in. To avoid confusion, this should either refer to a specific star column bug or not reference the jira. - Aman Sinha On March 7, 2015, 2:28 a.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31707/ > ----------------------------------------------------------- > > (Updated March 7, 2015, 2:28 a.m.) > > > Review request for drill, Aman Sinha and Jinfeng Ni. > > > Bugs: DRILL-2207 > https://issues.apache.org/jira/browse/DRILL-2207 > > > Repository: drill-git > > > Description > ------- > > DRILL-2207: New Union-All Implementation > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java > 3565bf4 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java > 99aec92 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAller.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllerTemplate.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java > 270462b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java > 4c9d301 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java > 60a9e4b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java > dcd5ebf > > exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java > baf74b1 > > exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java > f5b0de4 > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java > 225b21e > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b > exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q1.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q10.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q11.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q12.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q13.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q14.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q15.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q16.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q17.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q2.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q3.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q4.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q5.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6_1.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q7.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q8.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q9.tsv > PRE-CREATION > > Diff: https://reviews.apache.org/r/31707/diff/ > > > Testing > ------- > > Design Doc can be found from: > https://issues.apache.org/jira/browse/DRILL-2207 > > Unit, Customers, TPCH passed > waiting for Functional... > > > Thanks, > > Sean Hsuan-Yi Chu > >
