> On Jan. 29, 2015, 9:40 p.m., Mehant Baid wrote: > > Since this change touches about 50 files, I think it would be easier to > > review the changes if you separate out the code changes and the > > comment/TODO changes.
Roger. Split misc. TODO changes out from code changes. See new patch. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28686/#review70282 ----------------------------------------------------------- On Feb. 25, 2015, 9:37 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28686/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 9:37 p.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-1735 > https://issues.apache.org/jira/browse/DRILL-1735 > > > Repository: drill-git > > > Description > ------- > > This change hooks in the previously written but unused DrillHandler so that a > local-mode JDBC connection shuts down its embedded DrillBit. > > It also fixes a chain of follow-on bugs (mostly resource-deallocation > omissions) exposed by the original bug fixes. (See the commit message for > the list of bugs/fixes and other changes.) > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java > 04b955b > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java > d884200 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java > b079428 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java > 3da2ea9 > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java > b8480b4 > exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java > 99c6ab8 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java > 378e81a > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java > 7ccb64e > exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java 0272b23 > exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java > cf5829a > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java > 82d51f1 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java > 54e31b1 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java > 2c51ec0 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java fbe611f > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 88a6c6d > exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 974e786 > > exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java > PRE-CREATION > exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java > PRE-CREATION > exec/jdbc/src/test/java/org/apache/drill/jdbc/DriverTest.java PRE-CREATION > > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ConnectionCloseTest.java > PRE-CREATION > > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersTest.java > PRE-CREATION > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java > b2f86ea > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java > b627c38 > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java > 93925fe > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 0f9e25e > > Diff: https://reviews.apache.org/r/28686/diff/ > > > Testing > ------- > > Ran tests. > > > Thanks, > > Daniel Barclay > >
