-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28686/
-----------------------------------------------------------
(Updated March 19, 2015, 6:19 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
Added auto-closing of Statements when Connection is closed.
Bugs: DRILL-1735
https://issues.apache.org/jira/browse/DRILL-1735
Repository: drill-git
Description
-------
This change hooks in the previously written but unused DrillHandler so that a
local-mode JDBC connection shuts down its embedded DrillBit.
It also fixes a chain of follow-on bugs (mostly resource-deallocation
omissions) exposed by the original bug fixes. (See the commit message for the
list of bugs/fixes and other changes.)
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java
04b955b
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java
d884200
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
b079428
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java
3da2ea9
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java
b8480b4
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
8e0780b
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
e2f7bbf
exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java 0272b23
exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java
cf5829a
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java 82d51f1
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java
54e31b1
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java
2c51ec0
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java fbe611f
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java
cfcee8c
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 77b2c37
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java fec126e
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatementRegistry.java
cc797fa
exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 974e786
exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java
PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java
PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java
PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DriverTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 40b1445
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ConnectionCloseTest.java
PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersTest.java
PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java
b2f86ea
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 682fca3
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java
93925fe
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 0f9e25e
Diff: https://reviews.apache.org/r/28686/diff/
Testing
-------
Ran tests.
Thanks,
Daniel Barclay
