----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29997/ -----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra. Summary (updated) ----------------- DRILL-2439: Fix: getBoolean() doesn't work (for non-null values). Repository: drill-git Description (updated) ------- - Created regression test Drill2439GetBooleanSaysWrongTypeBugTest. - Added getBoolean(...) for SqlAccessor implementations for type Bit in SqlAccessors template. (Note: Patch depends on (must be applied after) patch for DRILL-2463.) Diffs (updated) ----- exec/java-exec/src/main/codegen/templates/SqlAccessors.java 3039e5c exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2439GetBooleanFailsSayingWrongTypeBugTest.java PRE-CREATION Diff: https://reviews.apache.org/r/29997/diff/ Testing (updated) ------- Ran new specific unit test and existing tests. Thanks, Daniel Barclay
