----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29997/#review77581 -----------------------------------------------------------
Ship it! Ship It! - Mehant Baid On March 23, 2015, 8:27 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29997/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 8:27 p.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Repository: drill-git > > > Description > ------- > > - Created regression test Drill2439GetBooleanSaysWrongTypeBugTest. > - Added getBoolean(...) for SqlAccessor implementations for type Bit in > SqlAccessors template. > > (Note: Patch depends on (must be applied after) patch for DRILL-2463.) > > > Diffs > ----- > > exec/java-exec/src/main/codegen/templates/SqlAccessors.java 3039e5c > > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2439GetBooleanFailsSayingWrongTypeBugTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29997/diff/ > > > Testing > ------- > > Ran new specific unit test and existing tests. > > > Thanks, > > Daniel Barclay > >
