----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33209/#review80158 -----------------------------------------------------------
Ship it! One small note. Otherwise, lgtm exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java <https://reviews.apache.org/r/33209/#comment129924> can you create a jira (and not it here) which tracks removing this and is dependent on Jinfeng's calcite rebase? - Jacques Nadeau On April 15, 2015, 5:28 a.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33209/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 5:28 a.m.) > > > Review request for drill and Jinfeng Ni. > > > Repository: drill-git > > > Description > ------- > > Create a cast to rename the view definition query row type to view field list > specified in CREATE VIEW statement. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java > cacf26b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java > 4347249 > exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java > 578eace > > Diff: https://reviews.apache.org/r/33209/diff/ > > > Testing > ------- > > Includes unittests. > > > Thanks, > > Venki Korukanti > >
