> On April 15, 2015, 6:11 a.m., Jinfeng Ni wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java, > > line 114 > > <https://reviews.apache.org/r/33209/diff/1/?file=929615#file929615line114> > > > > One question. Seems you call DrillRelOptUtil.createRename(), just to > > get the rowtype of this new project. Why can't you create a rowType with > > the desired field name directly?
Let me if this still makes sense after the refactoring. - Venki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33209/#review80165 ----------------------------------------------------------- On April 15, 2015, 2:50 p.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33209/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 2:50 p.m.) > > > Review request for drill and Jinfeng Ni. > > > Repository: drill-git > > > Description > ------- > > Create a cast to rename the view definition query row type to view field list > specified in CREATE VIEW statement. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java > cacf26b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java > 300d65d > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java > 4347249 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java > 325f770 > exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java > 578eace > > Diff: https://reviews.apache.org/r/33209/diff/ > > > Testing > ------- > > Includes unittests. > > > Thanks, > > Venki Korukanti > >
