-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33222/
-----------------------------------------------------------
(Updated April 20, 2015, 9:48 p.m.)
Review request for drill, Hanifi Gunes and Steven Phillips.
Changes
-------
fixed RepeatedListReaderImpl to properly handle nested lists
added more unit tests to TestRepeatedReaders
Bugs: DRILL-2292
https://issues.apache.org/jira/browse/DRILL-2292
Repository: drill-git
Description
-------
- fixed _RepeatedMapReaderImpl.setPosition()_ to handle when the index is
negative or _NO_VALUES_
- added unit test _TestRepeatedReaders.testReadNestedRepeatedMap()_
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java
767c366
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java
71a5017
exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java
PRE-CREATION
exec/java-exec/src/test/resources/parquet/2292.rl_in_rl.json PRE-CREATION
exec/java-exec/src/test/resources/parquet/2292.rl_in_rm.json PRE-CREATION
exec/java-exec/src/test/resources/parquet/2292.rm_in_rl.json PRE-CREATION
exec/java-exec/src/test/resources/parquet/2292.rm_in_rm.json PRE-CREATION
Diff: https://reviews.apache.org/r/33222/diff/
Testing
-------
all unit tests are passing along with regression, customer and tpch100
Thanks,
abdelhakim deneche
