----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33222/#review80841 -----------------------------------------------------------
Looks pretty. Almost there. exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java <https://reviews.apache.org/r/33222/#comment130946> We should consider moving this *super call* down the check. exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java <https://reviews.apache.org/r/33222/#comment130948> the same. exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java <https://reviews.apache.org/r/33222/#comment130949> As /tmp is platform dependent, you may want to use nio.Files#createTempFile or Guava's equivalent. We should get rid of *getRandomTableName*. exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java <https://reviews.apache.org/r/33222/#comment130951> The data file seems RM in MAP in RM. Perhaps we should keep this and add another test case for RM in RM. - Hanifi Gunes On April 20, 2015, 9:48 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33222/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 9:48 p.m.) > > > Review request for drill, Hanifi Gunes and Steven Phillips. > > > Bugs: DRILL-2292 > https://issues.apache.org/jira/browse/DRILL-2292 > > > Repository: drill-git > > > Description > ------- > > - fixed _RepeatedMapReaderImpl.setPosition()_ to handle when the index is > negative or _NO_VALUES_ > - added unit test _TestRepeatedReaders.testReadNestedRepeatedMap()_ > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java > 767c366 > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java > 71a5017 > exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java > PRE-CREATION > exec/java-exec/src/test/resources/parquet/2292.rl_in_rl.json PRE-CREATION > exec/java-exec/src/test/resources/parquet/2292.rl_in_rm.json PRE-CREATION > exec/java-exec/src/test/resources/parquet/2292.rm_in_rl.json PRE-CREATION > exec/java-exec/src/test/resources/parquet/2292.rm_in_rm.json PRE-CREATION > > Diff: https://reviews.apache.org/r/33222/diff/ > > > Testing > ------- > > all unit tests are passing along with regression, customer and tpch100 > > > Thanks, > > abdelhakim deneche > >
