----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33291/#review80903 -----------------------------------------------------------
What should our option be to handle clients that do not handle the exceptions thrown by these methods? We could check an environment variable and if it is set, then silently return from any of these calls instead of throwing an exception? exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java <https://reviews.apache.org/r/33291/#comment131070> Per the spec, one cannot call setTransactionLevel with TRANSACTION_NONE. Doesn't the parent method throw an exception? - Parth Chandra On April 20, 2015, 3:03 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33291/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 3:03 a.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2782 > https://issues.apache.org/jira/browse/DRILL-2782 > > > Repository: drill-git > > > Description > ------- > > - Added unit test. > - Added implementations of transaction-related methods: > - setAutoCommit - reject attempt to turn auto-commit off > - commit - reject when in auto-commit mode (which is always) > - rollback - reject when in auto-commit mode (which is always) > - other mode and metadata methods - roughly, report "no transactions" > - Added method declarations with doc. comments in Drill-specific interface. > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java a52644d > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java > 3fdbf84 > > exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTransactionMethodsTest.java > PRE-CREATION > exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33291/diff/ > > > Testing > ------- > > Ran new specific tests. > > Ran existing tests; no new problems. > > > Thanks, > > Daniel Barclay > >
