----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33291/#review81411 -----------------------------------------------------------
Ship it! LGTM - Parth Chandra On April 23, 2015, 9:16 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33291/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 9:16 p.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2782 > https://issues.apache.org/jira/browse/DRILL-2782 > > > Repository: drill-git > > > Description > ------- > > - Added unit test. > - Added implementations of transaction-related methods: > - setAutoCommit - reject attempt to turn auto-commit off > - commit - reject when in auto-commit mode (which is always) > - rollback - reject when in auto-commit mode (which is always) > - other mode and metadata methods - roughly, report "no transactions" > - Added method declarations with doc. comments in Drill-specific interface. > - Overrode SQLLine's default transaction isolation level to Drill's > TRANSACTION_NONE. > > > Diffs > ----- > > distribution/src/resources/sqlline 0852fba > distribution/src/resources/sqlline.bat 755526c > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java a52644d > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java > 3fdbf84 > > exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTransactionMethodsTest.java > PRE-CREATION > exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33291/diff/ > > > Testing > ------- > > Ran new specific tests. > > Ran existing tests; no new problems. > > > Thanks, > > Daniel Barclay > >
