----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32273/#review82553 -----------------------------------------------------------
Ship it! Ship It! - Venki Korukanti On May 5, 2015, 3:40 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32273/ > ----------------------------------------------------------- > > (Updated May 5, 2015, 3:40 p.m.) > > > Review request for drill, Aman Sinha, Jason Altekruse, and Venki Korukanti. > > > Bugs: DRILL-2408 > https://issues.apache.org/jira/browse/DRILL-2408 > > > Repository: drill-git > > > Description > ------- > > I updated ParquetRecordWriter to delete the last file created if it's empty > (no records written to it). I also added two unit tests one that checks the > default case where we try to create a table using a query that returns 0 > rows, the second case can happen if the ParquetRecordWriter flushes it's > content just after writing the last record, it will then create a new empty > file. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java > 3506ffa > exec/java-exec/src/main/java/org/apache/drill/exec/util/TestUtilities.java > a1fcc2a > exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java d6e6d08 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java > 5670e1e > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriterEmptyFiles.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java > c73eb50 > > Diff: https://reviews.apache.org/r/32273/diff/ > > > Testing > ------- > > - Added 2 unit tests to TestParquetWriter > - Unit tests are passing > > > Thanks, > > abdelhakim deneche > >
