-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32273/
-----------------------------------------------------------
(Updated May 7, 2015, 1:27 p.m.)
Review request for drill and Aman Sinha.
Changes
-------
Fixed ParquetRecordWriter to increment recordCount after parquet file is
successfully created
rebased on top of master
Bugs: DRILL-2408
https://issues.apache.org/jira/browse/DRILL-2408
Repository: drill-git
Description
-------
I updated ParquetRecordWriter to delete the last file created if it's empty (no
records written to it). I also added two unit tests one that checks the default
case where we try to create a table using a query that returns 0 rows, the
second case can happen if the ParquetRecordWriter flushes it's content just
after writing the last record, it will then create a new empty file.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
8615eb7
exec/java-exec/src/main/java/org/apache/drill/exec/util/TestUtilities.java
a1fcc2a
exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java 200bbc6
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
5670e1e
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriterEmptyFiles.java
PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java
c73eb50
Diff: https://reviews.apache.org/r/32273/diff/
Testing (updated)
-------
- Added 2 unit tests to TestParquetWriter
Unit tests are passing along with regression/tpch100
Thanks,
abdelhakim deneche
