----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33949/#review82861 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java <https://reviews.apache.org/r/33949/#comment133701> You should probably move the STOP check before the OUT_OF_MEMORY one. In case we receive both STOP on one side and an OOM on the other side we would actually return a STOP. The current implementation of AbstractRecordBatch.buildSchema() will fail the query in both cases, but we may change this in the future. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java <https://reviews.apache.org/r/33949/#comment133702> same here exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/NestedLoopJoinBatch.java <https://reviews.apache.org/r/33949/#comment133703> same here - abdelhakim deneche On May 7, 2015, 5:55 p.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33949/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 5:55 p.m.) > > > Review request for drill, abdelhakim deneche and Steven Phillips. > > > Repository: drill-git > > > Description > ------- > > DRILL-2476: Added BatchState.STOP in buildSchema() so AbstractRecordBatch > returns IterOutcome.STOP > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java > 9f6bea9 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java > 15fb7b5 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java > dd53477 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java > 6466f70 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/NestedLoopJoinBatch.java > d20bfa1 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java > c36b0d3 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java > e88bc67 > > Diff: https://reviews.apache.org/r/33949/diff/ > > > Testing > ------- > > > Thanks, > > Sudheesh Katkam > >
