----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33949/#review83284 -----------------------------------------------------------
+1 (non binding) - abdelhakim deneche On May 11, 2015, 8:36 p.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33949/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 8:36 p.m.) > > > Review request for drill, abdelhakim deneche and Steven Phillips. > > > Repository: drill-git > > > Description > ------- > > DRILL-2476: Added BatchState.STOP in buildSchema() so AbstractRecordBatch > returns IterOutcome.STOP > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java > c3e70f5 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java > 28a99d9 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java > 56ce0ee > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java > 0430f1b > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/NestedLoopJoinBatch.java > 4c86f5c > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java > 5d990f0 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java > 3159811 > > Diff: https://reviews.apache.org/r/33949/diff/ > > > Testing > ------- > > > Thanks, > > Sudheesh Katkam > >
