----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34022/ -----------------------------------------------------------
Review request for drill and Aman Sinha. Repository: drill-git Description ------- This patch modifies aggregate functions so when we perform an aggregate (other than count) on an empty set we get null (for both required and optional input types). Tdd file changes: Modified tdd files so that the output type of aggregate functions is optional Template file changes: Maintain a nonNullCount to indiciate if the output should be null or not. Diffs ----- exec/java-exec/src/main/codegen/data/AggrBitwiseLogicalTypes.tdd 2b72abd exec/java-exec/src/main/codegen/data/AggrTypes1.tdd 8952417 exec/java-exec/src/main/codegen/data/AggrTypes2.tdd ee64daf exec/java-exec/src/main/codegen/data/AggrTypes3.tdd 0c3a358 exec/java-exec/src/main/codegen/templates/AggrBitwiseLogicalTypeFunctions.java b159421 exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java 19a6d46 exec/java-exec/src/main/codegen/templates/AggrTypeFunctions2.java 6701f09 exec/java-exec/src/main/codegen/templates/AggrTypeFunctions3.java c005446 exec/java-exec/src/main/codegen/templates/DateIntervalAggrFunctions1.java e934167 exec/java-exec/src/main/codegen/templates/IntervalAggrFunctions2.java b29fa08 exec/java-exec/src/main/codegen/templates/VarCharAggrFunctions1.java 53474ea exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunctions.java 01db7c2 exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestAgg.java b39566a exec/java-exec/src/test/resources/parquet/alltypes_required.parquet PRE-CREATION Diff: https://reviews.apache.org/r/34022/diff/ Testing ------- Added unit tests. Thanks, Mehant Baid
