> On May 14, 2015, 1:35 p.m., abdelhakim deneche wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java, > > line 305 > > <https://reviews.apache.org/r/34191/diff/1/?file=958720#file958720line305> > > > > are we sure closeOutResources(), updateState() and sendFinalState() > > won't throw exceptions ? what happens if they do ??
closeOutResources() handles throwing exceptions. updateState(FINISHED) does not throw exceptions. sendFinalState() can throw exceptions if it is unable to connect to the Foreman node. I'll add a block in that case. - Sudheesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34191/#review83757 ----------------------------------------------------------- On May 14, 2015, 5:25 a.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34191/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 5:25 a.m.) > > > Review request for drill, Jacques Nadeau and Venki Korukanti. > > > Repository: drill-git > > > Description > ------- > > [DRILL-3052](https://issues.apache.org/jira/browse/DRILL-3052), > [DRILL-3066](https://issues.apache.org/jira/browse/DRILL-3066): > FragmentExecutor must cleanup exactly once > Cleanup includes, in order: > 1) closing out resources, > 2) updating to the correct terminal state, and > 3) sending the state to QueryManager exactly once > > In DRILL-3053 scenario, sendFinalState() is never called > In DRILL-3066 scenario, closeOutResources() is called twice > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java > 6b44ae3 > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java > f95fbe1 > > Diff: https://reviews.apache.org/r/34191/diff/ > > > Testing > ------- > > Passes all unit test and regression tests. Started another build. > > > Thanks, > > Sudheesh Katkam > >
