----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34191/#review83870 -----------------------------------------------------------
+1 (non binding) - abdelhakim deneche On May 14, 2015, 11:17 p.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34191/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 11:17 p.m.) > > > Review request for drill, abdelhakim deneche, Jacques Nadeau, and Venki > Korukanti. > > > Repository: drill-git > > > Description > ------- > > [DRILL-3052](https://issues.apache.org/jira/browse/DRILL-3052), > [DRILL-3066](https://issues.apache.org/jira/browse/DRILL-3066), > [DRILL-3072](https://issues.apache.org/jira/browse/DRILL-3072): > FragmentExecutor must cleanup exactly once (root or non-root) > > In DRILL-3052 scenario, sendFinalState() is never called > In DRILL-3066 scenario, closeOutResources() is called twice > In DRILL-3072 scenario, root was interrupted by a cancel signal that the root > itself sent > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java > 8c49d68 > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java > f95fbe1 > > Diff: https://reviews.apache.org/r/34191/diff/ > > > Testing > ------- > > Runnning unit and regression tests currently. > > > Thanks, > > Sudheesh Katkam > >
