----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32248/#review85455 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/AggregateUtils.java <https://reviews.apache.org/r/32248/#comment137027> Is it always true that getExpr will return SchemaPath in all cases? What if I have group by some expression? exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/AggregateUtils.java <https://reviews.apache.org/r/32248/#comment137035> Add "final" where necessary in the code. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/AggregateUtils.java <https://reviews.apache.org/r/32248/#comment137034> If you put "incomingSchema.getColumn(indexCol).getPath()" into a variable, you do not have to use this long expression mutiple times. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/AggregateUtils.java <https://reviews.apache.org/r/32248/#comment137036> Same comment as line 52. exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java <https://reviews.apache.org/r/32248/#comment137037> Will it work for select distinct *, colA, colB, etc? I'm wondering if we need the similar logic as the one in ProjectRecordBatch to handle such cases. - Jinfeng Ni On May 26, 2015, 11:28 a.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32248/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 11:28 a.m.) > > > Review request for drill, Aman Sinha and Jinfeng Ni. > > > Bugs: DRILL-2139 > https://issues.apache.org/jira/browse/DRILL-2139 > > > Repository: drill-git > > > Description > ------- > > Expand * at the run time > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/AggregateUtils.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java > e1b5909 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java > b252971 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java > 8871a5f > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java > 75bbc13 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestHashAggr.java > 3786bfd > exec/java-exec/src/test/resources/store/text/data/repeatedRows.json > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testExampleQueries/testSelectDistinctByStreamAgg.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testExampleQueries/testSelectDistinctOverJoin.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testHashAggr/testSelectDistinctByHashAgg.tsv > PRE-CREATION > > Diff: https://reviews.apache.org/r/32248/diff/ > > > Testing > ------- > > Unit and all QA tests passed. > > > Thanks, > > Sean Hsuan-Yi Chu > >
